Merge pull request #25 from reidmv/reduce_complexity

Reduce complexity

.gitignore

@@ -1,2 +1,3 @@
 pkg/
 .DS_Store
+metadata.json

CHANGELOG

@@ -1,3 +1,9 @@
+2013-04-04 Reid Vandewiele <reid@puppetlabs.com> - 0.3.0
+* Refactor, introduce params pattern
+
+2012-11-15 Scott Schneider <sschneider@puppetlabs.com> - 0.2.0
+* Add Solaris support
+
 2011-06-16 Jeff McCune <jeff@puppetlabs.com> - 0.1.5
 * Add Debian based distro (Lucid) support
 

LICENSE

@@ -0,0 +1,17 @@
+Puppet Java Module - Puppet module for managing Java
+
+Copyright (C) 2011 Puppet Labs Inc
+
+Puppet Labs can be contacted at: info@puppetlabs.com
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.

Modulefile

@@ -1,5 +1,5 @@
 name    'puppetlabs-java'
-version '0.1.5'
+version '0.3.0'
 source 'git://github.com/puppetlabs/puppetlabs-java'
 author 'puppetlabs'
 license 'Apache'

README.markdown

@@ -2,32 +2,4 @@
 
 Manage the Java runtime for use with other application software.
 
-Currently this simply deploys the package on Enterprise Linux based systems and Debian based systems.
+Currently this deploys the correct Java package on a variety of platforms.
-
-Tested on:
-
-  * Centos 5.6
-  * Ubuntu 10.04 Lucid
-
-# RedHat Support #
-
-The Java runtime this module is designed to configure are the RPM's provided by Oracle and obtained by extracting them from the "bin" installers.
-
-For example:
-
-    ./jdk-6u25-linux-x64-rpm.bin -x
-
-Please download the installer from:
-
- * [Java Downloads](http://www.oracle.com/technetwork/java/javase/downloads/jdk-6u25-download-346242.html)
-
-# Ubuntu Support #
-
-## Lucid ##
-
-You need to have the partner repository enabled in order to install the Sun JDK or JRE.
-
-    aptitude install python-software-properties
-    sudo add-apt-repository "deb http://archive.canonical.com/ lucid partner"
-    aptitude update
-

manifests/init.pp

@@ -4,56 +4,50 @@
 #
 # Parameters:
 #
+#  [*distribution*]
+#    The java distribution to install. Can be one of "jdk" or "jre".
+#
+#  [*version*]
+#    The version of java to install. By default, this module simply ensures
+#    that java is present, and does not require a specific version.
+#
+#  [*package*]
+#    The name of the java package. This is configurable in case a non-standard
+#    java package is desired.
+#
 # Actions:
 #
 # Requires:
 #
 # Sample Usage:
 #
-# [Remember: No empty lines between comments and class definition]
 class java(
   $distribution = 'jdk',
-  $version      = 'installed'
+  $version      = 'present',
+  $package      = undef,
 ) {
+  include java::params
 
-  validate_re($distribution, '^jdk$|^jre$')
+  validate_re($version, 'present|installed|latest|^[._0-9a-zA-Z:-]+$')
-  validate_re($version, 'installed|^[._0-9a-zA-Z:-]+$')
-
-  anchor { 'java::begin': }
-  anchor { 'java::end': }
-
-  case $operatingsystem {
-
-    centos, redhat, oel: {
-
-      class { 'java::package_redhat':
-        version      => $version,
-        distribution => $distribution,
-        require      => Anchor['java::begin'],
-        before       => Anchor['java::end'],
-      }
 
+  case $distribution {
+    default: { fail('distribution must be one of jdk, jre') }
+    'jdk': {
+      $default_package_name = $java::params::jdk_package
     }
-
+    'jre': {
-    debian, ubuntu: {
+      $default_package_name = $java::params::jre_package
-
-      $distribution_debian = $distribution ? {
-        jdk => 'sun-java6-jdk',
-        jre => 'sun-java6-jre',
-      }
-      class { 'java::package_debian':
-        version      => $version,
-        distribution => $distribution_debian,
-        require      => Anchor['java::begin'],
-        before       => Anchor['java::end'],
-      }
-
     }
+  }
 
-    default: {
+  $use_java_package_name = $package ? {
-      fail("operatingsystem $operatingsystem is not supported")
+    default => $package,
-    }
+    undef   => $default_package_name,
+  }
 
+  package { 'java':
+    ensure => $version,
+    name   => $use_java_package_name,
   }
 
 }

manifests/package_debian.pp

@@ -1,28 +0,0 @@
-# Class: java::package_debian
-#
-#   Implementation class of the Java package
-#   for debian based systems.
-#
-#   This class is not meant to be used by the end user
-#   of the module.  It is an implementation class
-#   of the composite Class[java]
-#
-# Parameters:
-#
-# Actions:
-#
-# Requires:
-#
-# Sample Usage:
-#
-class java::package_debian(
-  $version,
-  $distribution
-) {
-
-  package { 'java':
-    ensure => $version,
-    name   => $distribution,
-  }
-
-}

manifests/package_redhat.pp

@@ -1,28 +0,0 @@
-# Class: java::package_redhat
-#
-#   Implementation class of the Java package
-#   for redhat based systems.
-#
-#   This class is not meant to be used by the end user
-#   of the module.  It is an implementation class
-#   of the composite Class[java]
-#
-# Parameters:
-#
-# Actions:
-#
-# Requires:
-#
-# Sample Usage:
-#
-class java::package_redhat(
-  $version,
-  $distribution
-) {
-
-  package { 'java':
-    ensure => $version,
-    name   => $distribution,
-  }
-
-}

manifests/params.pp

@@ -0,0 +1,46 @@
+# Class: java::params
+#
+# This class sets the value of two variables, jdk_package and jre_package,
+# appropriate for the client system in question.
+#
+class java::params {
+
+  case $::osfamily {
+    default: { fail("unsupported platform ${::osfamily}") }
+    'RedHat': {
+      case $::operatingsystem {
+        default: { fail("unsupported os ${::operatingsystem}") }
+        'RedHat', 'CentOS': {
+          $jdk_package = 'java-1.7.0-openjdk-devel'
+          $jre_package = 'java-1.7.0-openjdk'
+        }
+        'Fedora': {
+          $jdk_package = 'java'
+          $jre_package = 'java'
+        }
+      }
+    }
+    'Debian': {
+      case $::lsbdistcodename {
+        default: { fail("unsupported release ${::lsbdistcodename}") }
+        'squeeze', 'lucid': {
+          $jdk_package = 'openjdk-6-jdk'
+          $jre_package = 'openjdk-6-jre-headless'
+        }
+        'wheezy', 'precise': {
+          $jdk_package = 'openjdk-7-jdk'
+          $jre_package = 'openjdk-7-jre-headless'
+        }
+      }
+    }
+    'Solaris': {
+      $jdk_package = 'developer/java/jdk-7'
+      $jre_package = 'runtime/java/jre-7'
+    }
+    'Suse': {
+      $jdk_package = 'java-1_6_0-ibm-devel'
+      $jre_package = 'java-1_6_0-ibm'
+    }
+  }
+
+}

metadata.json

@@ -1,12 +0,0 @@
-/*
-+-----------------------------------------------------------------------+
-|                                                                       |
-|                    ==> DO NOT EDIT THIS FILE! <==                     |
-|                                                                       |
-|   You should edit the `Modulefile` and run `puppet-module build`      |
-|   to generate the `metadata.json` file for your releases.             |
-|                                                                       |
-+-----------------------------------------------------------------------+
-*/
-
-{}

spec/spec.opts

@@ -1,6 +0,0 @@
---format
-s
---colour
---loadby
-mtime
---backtrace

spec/spec_helper.rb

@@ -1,18 +0,0 @@
-require 'pathname'
-dir = Pathname.new(__FILE__).parent
-$LOAD_PATH.unshift(dir, dir + 'lib', dir + '../lib')
-
-require 'mocha'
-require 'puppet'
-gem 'rspec', '=1.2.9'
-require 'spec/autorun'
-
-Spec::Runner.configure do |config|
-    config.mock_with :mocha
-end
-
-# We need this because the RAL uses 'should' as a method.  This
-# allows us the same behaviour but with a different method name.
-class Object
-    alias :must :should
-end

tests/init.pp

@@ -1,10 +1,4 @@
-node default {
+class { 'java':
-
+  distribution => 'jdk',
-  notify { "alpha": } ->
+  version      => 'latest',
-  class { 'java':
-    distribution => 'jdk',
-    version      => 'latest',
-  } ->
-  notify { "omega": }
-
 }