Apply remaining rubocop fixes

.rubocop.yml

@@ -89,6 +89,8 @@ Performance/CaseWhenSplat:
 Performance/Casecmp:
   Enabled: true
 Performance/CollectionLiteralInLoop:
+  Exclude:
+  - spec/**/*
   Enabled: true
 Performance/CompareWithBlock:
   Enabled: true
@@ -294,6 +296,8 @@ Metrics/AbcSize:
   Enabled: false
 Metrics/BlockLength:
   Enabled: false
+Metrics/BlockNesting:
+  Enabled: false
 Metrics/ClassLength:
   Enabled: false
 Metrics/CyclomaticComplexity:
@@ -308,6 +312,8 @@ Metrics/PerceivedComplexity:
   Enabled: false
 Migration/DepartmentName:
   Enabled: false
+Naming/AccessorMethodName:
+  Enabled: false
 Naming/BlockParameterName:
   Enabled: false
 Naming/HeredocDelimiterCase:

lib/facter/java_version.rb

@@ -37,7 +37,7 @@ Facter.add(:java_version) do
   confine operatingsystem: 'Darwin'
   has_weight 100
   setcode do
-    unless %r{Unable to find any JVMs matching version} =~ Facter::Util::Resolution.exec('/usr/libexec/java_home --failfast 2>&1')
+    unless Facter::Util::Resolution.exec('/usr/libexec/java_home --failfast 2>&1').include?('Unable to find any JVMs matching version')
       version = nil
       Facter::Util::Resolution.exec('java -Xmx12m -version 2>&1').lines.each { |line| version = Regexp.last_match(1) if %r{^.+ version \"(.+)\"} =~ line }
       version

spec/acceptance/install_spec.rb

@@ -189,19 +189,20 @@ install_sap_jdk_jre = <<EOL
   }
 EOL
 
-context 'installing java jre', unless: UNSUPPORTED_PLATFORMS.include?(os[:family]) do
+describe 'installing' do
+  context 'installing java jre' do
     it 'installs jre' do
       idempotent_apply(java_class_jre)
     end
-end
+  end
 
-context 'installing java jdk', unless: UNSUPPORTED_PLATFORMS.include?(os[:family]) do
+  context 'installing java jdk' do
     it 'installs jdk' do
       idempotent_apply(java_class)
     end
-end
+  end
 
-context 'with failure cases' do
+  context 'with failure cases' do
     it 'fails to install java with a blank version' do
       apply_manifest(blank_version, expect_failures: true)
     end
@@ -225,9 +226,9 @@ context 'with failure cases' do
         apply_manifest(bogus_alternative, expect_failures: true)
       end
     end
-end
+  end
 
-context 'java::oracle', if: oracle_enabled, unless: UNSUPPORTED_PLATFORMS.include?(os[:family]) do
+  context 'java::oracle', if: oracle_enabled, unless: UNSUPPORTED_PLATFORMS.include?(os[:family]) do
     let(:install_path) do
       (os[:family] == 'redhat') ? '/usr/java' : '/usr/lib/jvm'
     end
@@ -255,9 +256,9 @@ context 'java::oracle', if: oracle_enabled, unless: UNSUPPORTED_PLATFORMS.includ
       result = shell("test -e #{install_path}/jre1.#{oracle_version_major}.0_#{oracle_version_minor}#{version_suffix}/lib/security/local_policy.jar")
       expect(result.exit_code).to eq(0)
     end
-end
+  end
 
-context 'java::adopt', if: adopt_enabled, unless: UNSUPPORTED_PLATFORMS.include?(os[:family]) do
+  context 'java::adopt', if: adopt_enabled, unless: UNSUPPORTED_PLATFORMS.include?(os[:family]) do
     let(:install_path) do
       (os[:family] == 'redhat') ? '/usr/java' : '/usr/lib/jvm'
     end
@@ -269,9 +270,9 @@ context 'java::adopt', if: adopt_enabled, unless: UNSUPPORTED_PLATFORMS.include?
     it 'installs adopt jdk and jre' do
       idempotent_apply(install_adopt_jdk_jre)
     end
-end
+  end
 
-context 'java::adopt', if: sap_enabled && ['Sles'].include?(os[:family]), unless: UNSUPPORTED_PLATFORMS.include?(os[:family]) do
+  context 'java::adopt', if: sap_enabled && ['Sles'].include?(os[:family]), unless: UNSUPPORTED_PLATFORMS.include?(os[:family]) do
     let(:install_path) do
       (os[:family] == 'redhat') ? '/usr/java' : '/usr/lib/jvm'
     end
@@ -279,4 +280,5 @@ context 'java::adopt', if: sap_enabled && ['Sles'].include?(os[:family]), unless
     it 'installs adopt jdk and jre' do
       idempotent_apply(install_sap_jdk_jre)
     end
+  end
 end