RickRongen/puppetlabs-java
1
0
Fork 0
Code Releases Activity

(MODULES-4069) Fail when required params are not available in params.

Browse Source 
When overriding all values required for the java setup, there is
no need to fail if params.pp does not support the package.
This commit is contained in:
Jan Vansteenkiste
2016-11-07 14:58:13 +01:00
parent 62f054649a
commit c40b061d97
2 changed files with 60 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
spec/classes/java_spec.rb
View File

@@ -245,6 +245,34 @@ describe 'java', :type => :class do
it { is_expected.to contain_package('java').with_name('jre') }
end
describe 'custom java package' do
let(:facts) { {:osfamily => 'Debian', :operatingsystem => 'Debian', :lsbdistcodename => 'jessie', :operatingsystemrelease => '8.6', :architecture => 'amd64',} }
context 'all params provided' do
let(:params) { {
'distribution' => 'custom',
'package' => 'custom_jdk',
'java_alternative' => 'java-custom_jdk',
'java_alternative_path' => '/opt/custom_jdk/bin/java',
'java_home' => '/opt/custom_jdk',
} }
it { is_expected.to contain_package('java').with_name('custom_jdk') }
it { is_expected.to contain_file_line('java-home-environment').with_line('JAVA_HOME=/opt/custom_jdk') }
it { is_expected.to contain_exec('update-java-alternatives').with_command('update-java-alternatives --set java-custom_jdk --jre') }
end
context 'missing parameters' do
let(:params) { {
'distribution' => 'custom',
'package' => 'custom_jdk',
} }
it do
expect { catalogue }.to raise_error Puppet::Error, /is not supported. Missing default values/
end
end
end
describe 'incompatible OSs' do
[
{