From 693d980c2baa674d2ae6ca1b95ac334222b6736f Mon Sep 17 00:00:00 2001
From: Chris Edester <edestecd@miamioh.edu>
Date: Tue, 1 Nov 2016 12:53:29 -0400
Subject: [PATCH] java::oracle Do not download archive if already installed

We are having issues on reboot of boxes. It tries to download to tmp even though already installed, which would be fine,
but the version is no longer available.
This results in curl downloading something to tmp every time puppet runs, which eventualy fills up tmp :(
---
 manifests/oracle.pp | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/manifests/oracle.pp b/manifests/oracle.pp
index cc080a3..4ed9874 100644
--- a/manifests/oracle.pp
+++ b/manifests/oracle.pp
@@ -14,7 +14,7 @@
 #
 # Parameters
 # [*version*]
-# Version of Java to install, e.g. '7' or '8'. Default values for major and minor 
+# Version of Java to install, e.g. '7' or '8'. Default values for major and minor
 # versions will be used.
 #
 # [*version_major*]
@@ -24,7 +24,7 @@
 # [*version_minor*]
 # Minor version which should be installed, e.g. 'b12'. Must be used together with
 # version_major.
-# 
+#
 # [*java_se*]
 # Type of Java Standard Edition to install, jdk or jre.
 #
@@ -212,9 +212,10 @@ define java::oracle (
       archive { $destination :
         ensure       => present,
         source       => "${oracle_url}${release_major}-${release_minor}/${package_name}",
-        cleanup      => false,
-        extract_path => '/tmp',
         cookie       => 'gpw_e24=http%3A%2F%2Fwww.oracle.com%2F; oraclelicense=accept-securebackup-cookie',
+        extract_path => '/tmp',
+        cleanup      => false,
+        creates      => $creates_path,
       }->
       case $::kernel {
         'Linux' : {